fix: 忽略 Gemini “返回内容为空”的错误消息，将 OpenAI 和 Gemini 的此类消息以 info 级别输出在控制台上。 #2324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @MCjiaozi - 我已经审阅了你的更改 - 以下是一些反馈：
- 空响应处理逻辑在不同提供者之间重复；考虑将其提取到共享的帮助函数中以避免冗余。
- 与其记录空的
result_parts并继续执行，你可能希望提前返回一个空的MessageChain以提高清晰度。 - 考虑使用较低的日志级别 (debug) 或使空响应日志可配置，因为信息日志可能会使生产输出变得混乱。
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Empty response handling logic is duplicated across providers; consider extracting it into a shared helper to avoid redundancy.
- Rather than logging an empty `result_parts` and falling through, you may want to early-return an empty `MessageChain` for clarity.
- Consider using a lower log level (debug) or making the empty-response logs configurable, as info logs might clutter production output.Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Original comment in English
Hey @MCjiaozi - I've reviewed your changes - here's some feedback:
- Empty response handling logic is duplicated across providers; consider extracting it into a shared helper to avoid redundancy.
- Rather than logging an empty
result_partsand falling through, you may want to early-return an emptyMessageChainfor clarity. - Consider using a lower log level (debug) or making the empty-response logs configurable, as info logs might clutter production output.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Empty response handling logic is duplicated across providers; consider extracting it into a shared helper to avoid redundancy.
- Rather than logging an empty `result_parts` and falling through, you may want to early-return an empty `MessageChain` for clarity.
- Consider using a lower log level (debug) or making the empty-response logs configurable, as info logs might clutter production output.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Soulter
force-pushed
the
master
branch
2 times, most recently
from
257d742 to
b1e4bff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
此 PR 与 #2279 同类
Motivation
#2279 仅解决了 OpenAI 提供商的此类问题，此 PR 解决 Gemini 的空消息返回问题。
未对其他供应商做出相应更改是因为尚未测试其他供应商的模型。
Modifications
raise Exception("API 返回的内容为空。")改为logger.debug("API 可能返回了空消息。")，避免输出到消息平台logger.debug作为控制台提示。Check
requirements.txt和pyproject.toml文件相应位置。